Release 0.3 - PR3

Comments

Post a Comment

Popular posts from this blog

Hacktoberfest Part #5 (5nd PR of release 0.2)

Image
Last PR of release 0.2! Pull Request #5 As I mentioned in previous blog post, this PR will also be in JavaScript algorithms repository. For the last PR I chose the math algorithms of finding the sum of n inverse numbers. One of the hard things in this repository is that there are no instructions given for algorithms to be developed. That is why I decided to implement the precision of result returned. Sum of n inverse numbers is a result that can be represented in the following way: n = 7 result = 1 + 1/2 + 1/3 + 1/4 + 1/5 + 1/6 + 1/7 Logic of my algorithm: The idea is that we get 2 numbers from the input -  n  and  precision If n equals to 0 then function returns 'undefined' Otherwise, function calculates the sum of first 'n' inverse numbers  The last step is setting up the precision and returning the result After that I wrote this code and tests for it. https://github.com/manrajgrover/algorithms-js/pull/61
Read more

Hacktoberfest Part #4 (4nd PR of release 0.2)

Image
Fourth PR of release 0.2... Pull Request #4 For the next 2 pull requests I decided to stay in the same repository. For 4th PR I chose the string algorithm of finding the longest common substring. It was a little bit challenging to understand the logic of how to find it. Logic of my algorithm: The idea is we get 2 strings from the input, first and second If first bigger then second we swap them Then we need to iterate trough the second string, to find pieces of different sizes (from 1 to size of string) from first sting in the second string Once we find any piece from first string in the second string we return it The process continues until first string exists If string do not have any common substrings then program returns empty string After that I wrote this code and tests for it: And created the pull request: https://github.com/manrajgrover/algorithms-js/pull/60
Read more

Release 0.3 - PR2

Internal project - Seneca Blackboard Extension As I mentioned in previous blog post, for this release I had a chance to become a maintainer of the internal project and its repository - Seneca Blackboard Extension. After creating the basic file structure from “refined Twitter” extension example we started to work. As a maintainer of the repo I needed to control the issues and pull requests, but it was challenging. One of the reason is a couple of collisions - some people started to work on the same issues and I decided to create the rules for contributing to the repo, to avoid such collisions. The main rule of our repo is:  " FOR THIS REPOSITORY IT IS MANDATORY TO CREATE ISSUE OR COMMENT UNDER EXISTING ISSUE BEFORE CREATING THE PULL REQUEST." (CONTRIBUTING.md) After creating the rules it was much easier to assign issues to different students and accept pull requests according to the rules. Closer to the deadline of the Release 0.3 I faced the other problem that many repo ...
Read more