Hacktoberfest Part #2 (2nd PR of release 0.2)

Next week of Hacktoberfest and second PR of release 0.2...

Hacktoberfest is going on and our task for this week is to do a second pull request to one of the repositories on GitHub.

Pull Request #2

For the second pull request I decided to take some web project because I feel confident in html, css and javascript. After researching I have found the repository where the owner asked to develop a simple form just to practice and for future use I guess.


After looking through the code I have found out that the code is little messy and some css code are in the html file as an inline declaration. I decided to fix these small problems and created an issue.
After fixing the code I created the pull request.

Waiting my code to be merged will take some time I believe because repository seems to be not touched for 9 days and maybe author thinks it is dead right now, but I am planning to improve this form a lot in my future pull request because I know that some programmers often struggle with forms in html and this repository will definitely have the chance to help them.

Comments

Post a Comment

Popular posts from this blog

Hacktoberfest Final Blog Post

Hacktoberfest 2018 During this October in my Seneca course I had a chance to participate in a big Open Source event called Hacktoberfest. My task was to do 5 pull requests to open source repositories on GitHub. For the first PR I chose to add a hello world program in Pascal language For the second PR I chose to fix css and html in survey form project For the 3rd, 4th, 5th PRs I chose to add different math and string algorithms and tests to one of the standard algorithms repo in JavaScript Issues: https://github.com/piyush97/HelloWorld/issues/5 https://github.com/yirano/surveyForm-v1/issues/5 https://github.com/manrajgrover/algorithms-js/issues/10 (Find Divisors) https://github.com/manrajgrover/algorithms-js/issues/8 (Longest common substring) https://github.com/manrajgrover/algorithms-js/issues/10 (Inverse of first 'n' numbers) Pull Requests: https://github.com/piyush97/HelloWorld/pull/58 https://github.com/piyush97/HelloWorld/pull/57 https://github.com/yirano/surveyForm-
Read more

Release 0.3 - PR2

Internal project - Seneca Blackboard Extension As I mentioned in previous blog post, for this release I had a chance to become a maintainer of the internal project and its repository - Seneca Blackboard Extension. After creating the basic file structure from “refined Twitter” extension example we started to work. As a maintainer of the repo I needed to control the issues and pull requests, but it was challenging. One of the reason is a couple of collisions - some people started to work on the same issues and I decided to create the rules for contributing to the repo, to avoid such collisions. The main rule of our repo is:  " FOR THIS REPOSITORY IT IS MANDATORY TO CREATE ISSUE OR COMMENT UNDER EXISTING ISSUE BEFORE CREATING THE PULL REQUEST." (CONTRIBUTING.md) After creating the rules it was much easier to assign issues to different students and accept pull requests according to the rules. Closer to the deadline of the Release 0.3 I faced the other problem that many repo
Read more

Release 0.4 - PR3

Image
As I mentioned in previous blog post, for the very last PR for DPS909 course I will stay in JavaScript algorithms repository (https://github.com/manrajgrover/algorithms-js). After researching the repository I found out that GCD algorithm that is already in the repo does not filter the cases when user enters real numbers instead of integers.  So, I have improved a GCD algorithm. Now GCD algorithm filters the cases when user enters real numbers instead of integers. Tests are improved also. Codes are below:
Read more