Release 0.4 - PR2

For the second and third pull requests for the last release I decided to create couple of the algorithms and tests for open source project on GitHub. In October I found the repo where owner asked to implement standard algorithms using JavaScript and write tests for them.
For this PR I took Leonardo numbers function, commented about this in the issues and started to work. This function takes n as an input, and then returns all Leonardo numbers up to n. 

https://en.wikipedia.org/wiki/Leonardo_number

Code of this function you can see below.

Test for this function:

I tested my function and created the pull request.
https://github.com/manrajgrover/algorithms-js/pull/69

Comments

Post a Comment

Popular posts from this blog

Hacktoberfest Final Blog Post

Hacktoberfest 2018 During this October in my Seneca course I had a chance to participate in a big Open Source event called Hacktoberfest. My task was to do 5 pull requests to open source repositories on GitHub. For the first PR I chose to add a hello world program in Pascal language For the second PR I chose to fix css and html in survey form project For the 3rd, 4th, 5th PRs I chose to add different math and string algorithms and tests to one of the standard algorithms repo in JavaScript Issues: https://github.com/piyush97/HelloWorld/issues/5 https://github.com/yirano/surveyForm-v1/issues/5 https://github.com/manrajgrover/algorithms-js/issues/10 (Find Divisors) https://github.com/manrajgrover/algorithms-js/issues/8 (Longest common substring) https://github.com/manrajgrover/algorithms-js/issues/10 (Inverse of first 'n' numbers) Pull Requests: https://github.com/piyush97/HelloWorld/pull/58 https://github.com/piyush97/HelloWorld/pull/57 https://github.com/yirano/surveyForm-...
Read more

Release 0.3 - PR1

Beginning of the internal project For this release I had a chance to become a maintainer of the  internal project and its repository - Seneca Blackboard Extension. After creating a repo on GitHub, our team decided to develop an extension for Google Chrome, then we filed around 15 issues(we had 2 types of issues - new features/design and deleting useless parts), created the basic file structure from “refined Twitter” extension example and started to work. As a maintainer of repo and student of DPS909 I needed to do both sets of tasks - maintaining a repo and contributing to code. Here are the things that I finished in first PR: Contributor's tasks:  Basic file system created with small fixes  How to contribute section with rules added  Small ReadMe fixes done Repository maintainer's tasks:  Cleaning the issues & communicating with contributors about issues  Reviving & accepting the pull request, communicating with contr...
Read more

Release 0.3 - PR2

Internal project - Seneca Blackboard Extension As I mentioned in previous blog post, for this release I had a chance to become a maintainer of the internal project and its repository - Seneca Blackboard Extension. After creating the basic file structure from “refined Twitter” extension example we started to work. As a maintainer of the repo I needed to control the issues and pull requests, but it was challenging. One of the reason is a couple of collisions - some people started to work on the same issues and I decided to create the rules for contributing to the repo, to avoid such collisions. The main rule of our repo is:  " FOR THIS REPOSITORY IT IS MANDATORY TO CREATE ISSUE OR COMMENT UNDER EXISTING ISSUE BEFORE CREATING THE PULL REQUEST." (CONTRIBUTING.md) After creating the rules it was much easier to assign issues to different students and accept pull requests according to the rules. Closer to the deadline of the Release 0.3 I faced the other problem that many repo ...
Read more