Posts

Release 0.3 - PR2

Internal project - Seneca Blackboard Extension As I mentioned in previous blog post, for this release I had a chance to become a maintainer of the internal project and its repository - Seneca Blackboard Extension. After creating the basic file structure from “refined Twitter” extension example we started to work. As a maintainer of the repo I needed to control the issues and pull requests, but it was challenging. One of the reason is a couple of collisions - some people started to work on the same issues and I decided to create the rules for contributing to the repo, to avoid such collisions. The main rule of our repo is:  " FOR THIS REPOSITORY IT IS MANDATORY TO CREATE ISSUE OR COMMENT UNDER EXISTING ISSUE BEFORE CREATING THE PULL REQUEST." (CONTRIBUTING.md) After creating the rules it was much easier to assign issues to different students and accept pull requests according to the rules. Closer to the deadline of the Release 0.3 I faced the other problem that many repo ...

Release 0.3 - PR1

Beginning of the internal project For this release I had a chance to become a maintainer of the  internal project and its repository - Seneca Blackboard Extension. After creating a repo on GitHub, our team decided to develop an extension for Google Chrome, then we filed around 15 issues(we had 2 types of issues - new features/design and deleting useless parts), created the basic file structure from “refined Twitter” extension example and started to work. As a maintainer of repo and student of DPS909 I needed to do both sets of tasks - maintaining a repo and contributing to code. Here are the things that I finished in first PR: Contributor's tasks:  Basic file system created with small fixes  How to contribute section with rules added  Small ReadMe fixes done Repository maintainer's tasks:  Cleaning the issues & communicating with contributors about issues  Reviving & accepting the pull request, communicating with contr...

Hacktoberfest Part #3 (3nd PR of release 0.2)

Image
Third week of Hacktoberfest and third PR of release 0.2... Pull Request #3 For the third pull request I decided to take something harder. On GitHub I found the repo where owner asked to implement standard algorithms using JavaScript and write tests for them. I chose the Find Divisors function, commented about this in the issues and started to work. This function takes n as an input, and then returns all divisors of the n in the array. Code of this function you can see below. Moreover I needed to write tests for it. I tested my function and created the pull request. https://github.com/manrajgrover/algorithms-js/pull/59

Hacktoberfest Final Blog Post

Hacktoberfest 2018 During this October in my Seneca course I had a chance to participate in a big Open Source event called Hacktoberfest. My task was to do 5 pull requests to open source repositories on GitHub. For the first PR I chose to add a hello world program in Pascal language For the second PR I chose to fix css and html in survey form project For the 3rd, 4th, 5th PRs I chose to add different math and string algorithms and tests to one of the standard algorithms repo in JavaScript Issues: https://github.com/piyush97/HelloWorld/issues/5 https://github.com/yirano/surveyForm-v1/issues/5 https://github.com/manrajgrover/algorithms-js/issues/10 (Find Divisors) https://github.com/manrajgrover/algorithms-js/issues/8 (Longest common substring) https://github.com/manrajgrover/algorithms-js/issues/10 (Inverse of first 'n' numbers) Pull Requests: https://github.com/piyush97/HelloWorld/pull/58 https://github.com/piyush97/HelloWorld/pull/57 https://github.com/yirano/surveyForm-...

Hacktoberfest Part #5 (5nd PR of release 0.2)

Image
Last PR of release 0.2! Pull Request #5 As I mentioned in previous blog post, this PR will also be in JavaScript algorithms repository. For the last PR I chose the math algorithms of finding the sum of n inverse numbers. One of the hard things in this repository is that there are no instructions given for algorithms to be developed. That is why I decided to implement the precision of result returned. Sum of n inverse numbers is a result that can be represented in the following way: n = 7 result = 1 + 1/2 + 1/3 + 1/4 + 1/5 + 1/6 + 1/7 Logic of my algorithm: The idea is that we get 2 numbers from the input -  n  and  precision If n equals to 0 then function returns 'undefined' Otherwise, function calculates the sum of first 'n' inverse numbers  The last step is setting up the precision and returning the result After that I wrote this code and tests for it. https://github.com/manrajgrover/algorithms-js/pull/61

Hacktoberfest Part #4 (4nd PR of release 0.2)

Image
Fourth PR of release 0.2... Pull Request #4 For the next 2 pull requests I decided to stay in the same repository. For 4th PR I chose the string algorithm of finding the longest common substring. It was a little bit challenging to understand the logic of how to find it. Logic of my algorithm: The idea is we get 2 strings from the input, first and second If first bigger then second we swap them Then we need to iterate trough the second string, to find pieces of different sizes (from 1 to size of string) from first sting in the second string Once we find any piece from first string in the second string we return it The process continues until first string exists If string do not have any common substrings then program returns empty string After that I wrote this code and tests for it: And created the pull request: https://github.com/manrajgrover/algorithms-js/pull/60

Hacktoberfest Part #2 (2nd PR of release 0.2)

Image
Next week of Hacktoberfest and second PR of release 0.2... Hacktoberfest is going on and our task for this week is to do a second pull request to one of the repositories on GitHub. Pull Request #2 For the second pull request I decided to take some web project because I feel confident in html, css and javascript. After researching I have found the repository where the owner asked to develop a simple form just to practice and for future use I guess. After looking through the code I have found out that the code is little messy and some css code are in the html file as an inline declaration. I decided to fix these small problems and created an issue. After fixing the code I created the pull request. Waiting my code to be merged will take some time I believe because repository seems to be not touched for 9 days and maybe author thinks it is dead right now, but I am planning to improve this form a lot in my future pull request because I know that some programmers oft...