Hacktoberfest Part #4 (4nd PR of release 0.2)

Fourth PR of release 0.2...

Pull Request #4
For the next 2 pull requests I decided to stay in the same repository. For 4th PR I chose the string algorithm of finding the longest common substring. It was a little bit challenging to understand the logic of how to find it.

Logic of my algorithm:

  • The idea is we get 2 strings from the input, first and second
  • If first bigger then second we swap them
  • Then we need to iterate trough the second string, to find pieces of different sizes (from 1 to size of string) from first sting in the second string
  • Once we find any piece from first string in the second string we return it
  • The process continues until first string exists
  • If string do not have any common substrings then program returns empty string
After that I wrote this code and tests for it:



And created the pull request:
https://github.com/manrajgrover/algorithms-js/pull/60

Comments

Post a Comment

Popular posts from this blog

Release 0.3 - PR2

Internal project - Seneca Blackboard Extension As I mentioned in previous blog post, for this release I had a chance to become a maintainer of the internal project and its repository - Seneca Blackboard Extension. After creating the basic file structure from “refined Twitter” extension example we started to work. As a maintainer of the repo I needed to control the issues and pull requests, but it was challenging. One of the reason is a couple of collisions - some people started to work on the same issues and I decided to create the rules for contributing to the repo, to avoid such collisions. The main rule of our repo is:  " FOR THIS REPOSITORY IT IS MANDATORY TO CREATE ISSUE OR COMMENT UNDER EXISTING ISSUE BEFORE CREATING THE PULL REQUEST." (CONTRIBUTING.md) After creating the rules it was much easier to assign issues to different students and accept pull requests according to the rules. Closer to the deadline of the Release 0.3 I faced the other problem that many repo
Read more

Hacktoberfest Final Blog Post

Hacktoberfest 2018 During this October in my Seneca course I had a chance to participate in a big Open Source event called Hacktoberfest. My task was to do 5 pull requests to open source repositories on GitHub. For the first PR I chose to add a hello world program in Pascal language For the second PR I chose to fix css and html in survey form project For the 3rd, 4th, 5th PRs I chose to add different math and string algorithms and tests to one of the standard algorithms repo in JavaScript Issues: https://github.com/piyush97/HelloWorld/issues/5 https://github.com/yirano/surveyForm-v1/issues/5 https://github.com/manrajgrover/algorithms-js/issues/10 (Find Divisors) https://github.com/manrajgrover/algorithms-js/issues/8 (Longest common substring) https://github.com/manrajgrover/algorithms-js/issues/10 (Inverse of first 'n' numbers) Pull Requests: https://github.com/piyush97/HelloWorld/pull/58 https://github.com/piyush97/HelloWorld/pull/57 https://github.com/yirano/surveyForm-
Read more

Release 0.4 - PR3

Image
As I mentioned in previous blog post, for the very last PR for DPS909 course I will stay in JavaScript algorithms repository (https://github.com/manrajgrover/algorithms-js). After researching the repository I found out that GCD algorithm that is already in the repo does not filter the cases when user enters real numbers instead of integers.  So, I have improved a GCD algorithm. Now GCD algorithm filters the cases when user enters real numbers instead of integers. Tests are improved also. Codes are below:
Read more