release 0.1

Release 0.1 - Blog Post #opensource


The begging - LAB 2

At the beginning of the lab 2 (which is the part of this assignment) I started to work on the bug called
"Add test for mkdir with restricted symbols. I noticed that there isn't a test for the case that you call mkdir with a path that includes a restricted symbol. It should fail to create the illegal path name."
But when I started to work on release I had a conversation with my professor - David and we found out that this is not even a bug, and it shouldn't be fixed, because node actually let's you to create invalid path and we need to do it as well. The function that was written for that "bug" is below:

it('Should not create dir with restricted symbols (using promises)', () => {
var fsPromises = util.fs().promises;
return fsPromises.mkdir('/?').catch(error => {
expect(error).to.exist;
expect(error.code).to.equal('ENOENT');
});
});

So finally we decided that I will work on different thing.

Release 0.1 - My Contribution

For this assignment I have been working on:
"Converting an existing mkdir callback test to use promises"
The function that I have been converting is:

it('should return an error if the path already exists', function(done) {
var fs = util.fs();

fs.mkdir('/', function(error) {
expect(error).to.exist;
expect(error.code).to.equal('EEXIST');
done();
});
});

This function was easy to convert because I already had the promises template from previous "bug" and just needed to fix little things such as mkdir parameter and code error, the code is bellow:

it('should return an error if the path already exists (using promises)', () => {
var fsPromises = util.fs().promises;
return fsPromises.mkdir('/').catch(error => {
expect(error).to.exist;
expect(error.code).to.equal('EEXIST');
});
});

In this assignment I have learned how the git works, the hardest part was to understand the logic of git: pull requests, different branches, etc. As well I researched how node and filer work to fix the issue.

Issue : https://github.com/filerjs/filer/issues/491
Pull Request: https://github.com/filerjs/filer/pull/501

Pull Request That I Reviewed

I just made a clarification: 
If test for "r" was working, then for "r+" it should working also, because "r+" comparing to "r" has no limitations

Evidence of Community Involvement

I have been reading lots of pull request and the researched them, and this helped me to gain basic understanding of Filer.

Comments

Post a Comment

Popular posts from this blog

Release 0.3 - PR2

Internal project - Seneca Blackboard Extension As I mentioned in previous blog post, for this release I had a chance to become a maintainer of the internal project and its repository - Seneca Blackboard Extension. After creating the basic file structure from “refined Twitter” extension example we started to work. As a maintainer of the repo I needed to control the issues and pull requests, but it was challenging. One of the reason is a couple of collisions - some people started to work on the same issues and I decided to create the rules for contributing to the repo, to avoid such collisions. The main rule of our repo is:  " FOR THIS REPOSITORY IT IS MANDATORY TO CREATE ISSUE OR COMMENT UNDER EXISTING ISSUE BEFORE CREATING THE PULL REQUEST." (CONTRIBUTING.md) After creating the rules it was much easier to assign issues to different students and accept pull requests according to the rules. Closer to the deadline of the Release 0.3 I faced the other problem that many repo
Read more

Release 0.4 - PR3

Image
As I mentioned in previous blog post, for the very last PR for DPS909 course I will stay in JavaScript algorithms repository (https://github.com/manrajgrover/algorithms-js). After researching the repository I found out that GCD algorithm that is already in the repo does not filter the cases when user enters real numbers instead of integers.  So, I have improved a GCD algorithm. Now GCD algorithm filters the cases when user enters real numbers instead of integers. Tests are improved also. Codes are below:
Read more

Hacktoberfest Final Blog Post

Hacktoberfest 2018 During this October in my Seneca course I had a chance to participate in a big Open Source event called Hacktoberfest. My task was to do 5 pull requests to open source repositories on GitHub. For the first PR I chose to add a hello world program in Pascal language For the second PR I chose to fix css and html in survey form project For the 3rd, 4th, 5th PRs I chose to add different math and string algorithms and tests to one of the standard algorithms repo in JavaScript Issues: https://github.com/piyush97/HelloWorld/issues/5 https://github.com/yirano/surveyForm-v1/issues/5 https://github.com/manrajgrover/algorithms-js/issues/10 (Find Divisors) https://github.com/manrajgrover/algorithms-js/issues/8 (Longest common substring) https://github.com/manrajgrover/algorithms-js/issues/10 (Inverse of first 'n' numbers) Pull Requests: https://github.com/piyush97/HelloWorld/pull/58 https://github.com/piyush97/HelloWorld/pull/57 https://github.com/yirano/surveyForm-
Read more